update annotations for 7088 and update code examples for 2592

SonarSource · Aug 15, 2023 · aca8f6e · aca8f6e
1 parent 18aff85
commit aca8f6e
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 20 deletions.
diff --git a/...lyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.CSharp7.cs b/...lyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.CSharp7.cs
@@ -162,24 +162,24 @@ void NonCompliant1()
     // https://github.com/SonarSource/sonar-dotnet/issues/2592
     public class LoopsAreNotVisited
     {
-        public void DoWhileWithPattern()
+        public void DoWhileWithPattern(bool cond)
         {
-            var done = false;
+            bool done;
             do
             {
-                done = true;
+                done = cond;
             }
-            while (done is false); // Noncompliant FP
+            while (done is false); // Compliant
         }
 
-        public void DoWhile()
+        public void DoWhile(bool cond)
         {
-            var done = false;
+            bool done;
             do
             {
-                done = true;
+                done = cond;
             }
-            while (done == false); // Noncompliant FP
+            while (done == false); // Compliant
         }
 
         public static void M(string path, int timeoutmilliseconds = 500)

diff --git a/...lyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.CSharp8.cs b/...lyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.CSharp8.cs
@@ -400,7 +400,7 @@ void Method()
             sb.Append(i);
         }
 
-        if (sb is null) // Noncompliant FP
+        if (sb is null) // Noncompliant
         {
             Console.WriteLine("NULL");
         }

diff --git a/...alyzer.UnitTest/TestCases/SymbolicExecution/Sonar/ConditionEvaluatesToConstant.CSharp7.cs b/...alyzer.UnitTest/TestCases/SymbolicExecution/Sonar/ConditionEvaluatesToConstant.CSharp7.cs
@@ -163,24 +163,24 @@ void NonCompliant1()
     // https://github.com/SonarSource/sonar-dotnet/issues/2592
     public class LoopsAreNotVisited
     {
-        public void DoWhileWithPattern()
+        public void DoWhileWithPattern(bool cond)
         {
-            var done = false;
+            bool done;
             do
-            { // Secondary
-                done = true;
+            {
+                done = cond;
             }
-            while (done is false); // Noncompliant FP
+            while (done is false); // Compliant
         }
 
-        public void DoWhile()
+        public void DoWhile(bool cond)
         {
-            var done = false;
+            bool done;
             do
-            { // Secondary
-                done = true;
+            {
+                done = cond;
             }
-            while (done == false); // Noncompliant FP
+            while (done == false); // Compliant
         }
 
         public static void M(string path, int timeoutmilliseconds = 500)

diff --git a/...alyzer.UnitTest/TestCases/SymbolicExecution/Sonar/ConditionEvaluatesToConstant.CSharp8.cs b/...alyzer.UnitTest/TestCases/SymbolicExecution/Sonar/ConditionEvaluatesToConstant.CSharp8.cs
@@ -373,7 +373,7 @@ void Method()
             sb.Append(i);
         }
 
-        if (sb is null) // Noncompliant FP
+        if (sb is null) // Noncompliant
         {
             Console.WriteLine("NULL");
         }