New rule S2589/S2583 for VB.NET #7727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
force-pushed
the
mary/vb-2589-2583
branch
8 times, most recently
from
23833a6 to
ef300be
Compare
|
@Tim-Pohlmann Take a first look - implementation + UTs is done. Ignore Reworked secondary locations commit. EDIT: This commit was reverted. |
This reverts commit 4137efa.
mary-georgiou-sonarsource
force-pushed
the
mary/vb-2589-2583
branch
from
7f8ea16 to
1bc0abf
Compare
Tim-Pohlmann
requested changes
Aug 10, 2023
...Analyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.CSharp9.cs
Show resolved
Hide resolved
...narAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.VB14.vb
Outdated
Show resolved
Hide resolved
...narAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.VB14.vb
Outdated
Show resolved
Hide resolved
...narAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.VB14.vb
Outdated
Show resolved
Hide resolved
...narAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.VB14.vb
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.vb
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.vb
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.vb
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.vb
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.vb
Outdated
Show resolved
Hide resolved
Comment on lines
+205
to
+209
| If sObj?.str?.Length > 2 Then | ||
| ' ^^^^ Noncompliant | ||
| ' ^^^^^^^ Secondary@-1 | ||
| ' ^^^^^^^^^^^^^^^^^^^^^ Noncompliant@-2 | ||
| Console.WriteLine("a") ' Secondary |
There was a problem hiding this comment.
The length of the Secondary location is off. But this will be fixed by #7725
Comment on lines
+230
to
+233
| Dim sObj = Nothing | ||
| Dim x = sObj?.str?.Length > 2 | ||
| ' ^^^^ Noncompliant | ||
| ' ^^^^^^^ Secondary@-1 |
There was a problem hiding this comment.
The length of the Secondary location is off. But this will be fixed by #7725
Comment on lines
582
to
583
| a = a & true; | ||
| if (a) // FN |
There was a problem hiding this comment.
This is only an FN because of the compound assignments above. Needs to be separated.
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.vb
Outdated
Show resolved
Hide resolved
Tim-Pohlmann
approved these changes
Aug 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7647
Fixes #7648
RSPEC for S2583: SonarSource/rspec#2857
RSPEC for S2589: SonarSource/rspec#2856