Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S2589: Boolean expressions should not be gratuitous - for VB.NET #7648

Closed
mary-georgiou-sonarsource opened this issue Jul 24, 2023 · 0 comments · Fixed by #7727
Closed

New rule S2589: Boolean expressions should not be gratuitous - for VB.NET #7648

mary-georgiou-sonarsource opened this issue Jul 24, 2023 · 0 comments · Fixed by #7727
Assignees
@mary-georgiou-sonarsource
Labels
Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Type: New Rule Implementation for a rule that HAS been specified.
Milestone
9.8

Comments

@mary-georgiou-sonarsource
Copy link
Contributor

Implement S2589 for VB.NET

  • Create VB.NET test cases (based on the C# test cases)
  • set ShouldExecute to always return true
  • modify rule logic if necessary to accommodate VB.NET test cases
  • Update ITs
  • implement ShouldExecute for VB.NET
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Type: New Rule Implementation for a rule that HAS been specified.
Projects
None yet
Milestone
9.8
Development

Successfully merging a pull request may close this issue.

New rule S2589/S2583 for VB.NET SonarSource/sonar-dotnet
3 participants
@Tim-Pohlmann @mary-georgiou-sonarsource @martin-strecker-sonarsource