Fix S2589 FP: When condition that evaluates to constant is a constant field. #7708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
force-pushed
the
mary/S2589-constants
branch
from
dbb3f87 to
9f9c44d
Compare
mary-georgiou-sonarsource
changed the base branch from
master
to
feature/MMF-2563
mary-georgiou-sonarsource
force-pushed
the
mary/S2589-constants
branch
from
9e26499 to
4e90bc7
Compare
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
changed the title
Tim-Pohlmann
requested changes
Aug 1, 2023
| @@ -43,7 +43,8 @@ public override ProgramState ConditionEvaluated(SymbolicContext context) | |||
| { | |||
| var operation = context.Operation.Instance; | |||
| if (operation.Kind is not OperationKindEx.Literal | |||
| && operation.Syntax.Ancestors().Any(IsUsing) is false) | |||
| && operation.Syntax.Ancestors().Any(IsUsing) is false | |||
| && !IsConstField(operation)) | |||
There was a problem hiding this comment.
I wonder if we should just use !operation.ConstantValue.HasValue instead. Let's keep that option in mind and see if we get other annoying FPs with the field approach.
...SonarAnalyzer.Common/SymbolicExecution/Roslyn/RuleChecks/ConditionEvaluatesToConstantBase.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/MethodParameterUnused.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.cs
Outdated
Show resolved
Hide resolved
|
Do we have tests like |
mary-georgiou-sonarsource
force-pushed
the
mary/S2589-constants
branch
from
2009087 to
d3c38b2
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/S2589-constants
branch
from
e114c8a to
6dec1e3
Compare
| { | ||
| var x = t || a || b; // Compliant t is const | ||
|
|
||
| if (t == true) // Noncompliant |
There was a problem hiding this comment.
This should be indeed noncompliant as we are evaluating the whole condition as a whole t == true.
Am I missing something?
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Tim-Pohlmann
pushed a commit
that referenced
this pull request
Aug 7, 2023
Tim-Pohlmann
pushed a commit
that referenced
this pull request
Aug 8, 2023
Tim-Pohlmann
pushed a commit
that referenced
this pull request
Aug 8, 2023
Tim-Pohlmann
pushed a commit
that referenced
this pull request
Aug 8, 2023
sebastien-marichal
pushed a commit
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7646