fix and make condition shorter

SonarSource · Jul 31, 2023 · 9e26499 · 9e26499
1 parent 9f9c44d
commit 9e26499
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/...arAnalyzer.Common/SymbolicExecution/Roslyn/RuleChecks/ConditionEvaluatesToConstantBase.cs b/...arAnalyzer.Common/SymbolicExecution/Roslyn/RuleChecks/ConditionEvaluatesToConstantBase.cs
@@ -58,10 +58,8 @@ public override ProgramState ConditionEvaluated(SymbolicContext context)
         return base.ConditionEvaluated(context);
 
         static bool IsConstField(IOperation operation) =>
-           operation?.TrackedSymbol() is { } symbol
-           && symbol as IFieldSymbol is { } field
+           operation?.TrackedSymbol() as IFieldSymbol is { } field
            && field.IsConst;
-
     }
 
     public override void ExecutionCompleted()

diff --git a/...lyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.CSharp7.cs b/...lyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.CSharp7.cs
@@ -203,7 +203,7 @@ public static void M_Fixed(string path, int timeoutmilliseconds = 500)
             do
             {
                 try
-                {s
+                {
                     Console.WriteLine("May throw");
                     deletesuccess = true;
                 }
@@ -415,7 +415,7 @@ public void MemberBinding2(Exception ex)
             {
             }
             else if (ex == null)            // Compliant
-            {                      
+            {
             }
             else if (ex.Message != null)    // FN
             {
@@ -439,13 +439,13 @@ public void Foo()
             string str = value;
 
             if (str == null)    // Compliant
-            {               
+            {
                 Console.WriteLine("null");
             }
 
             bool? b = value;
             if (b == null)      // Compliant
-            {             
+            {
                 Console.WriteLine("null");
             }
         }