Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Token Type Utility Analyzer: Avoid allocations #6785

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting
  • Loading branch information
martin-strecker-sonarsource committed Feb 24, 2023
commit e9b2f70a9c062897176ac145ef8bd9f37e8573a7
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public class TokenTypeAnalyzer : TokenTypeAnalyzerBase<SyntaxKind>

protected override TokenClassifierBase GetTokenClassifier(SemanticModel semanticModel, bool skipIdentifierTokens) =>
new TokenClassifier(semanticModel, skipIdentifierTokens);

protected override TriviaClassifierBase GetTriviaClassifier() =>
new TriviaClassifier();

Expand Down Expand Up @@ -64,7 +65,7 @@ protected override bool IsStringLiteral(SyntaxToken token) =>
SyntaxKindEx.InterpolatedRawStringEndToken);
}

private sealed class TriviaClassifier: TriviaClassifierBase
private sealed class TriviaClassifier : TriviaClassifierBase
{
protected override bool IsRegularComment(SyntaxTrivia trivia) =>
trivia.IsAnyKind(SyntaxKind.SingleLineCommentTrivia, SyntaxKind.MultiLineCommentTrivia);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public class TokenTypeAnalyzer : TokenTypeAnalyzerBase<SyntaxKind>

protected override TokenClassifierBase GetTokenClassifier(SemanticModel semanticModel, bool skipIdentifierTokens) =>
new TokenClassifier(semanticModel, skipIdentifierTokens);

protected override TriviaClassifierBase GetTriviaClassifier() =>
new TriviaClassifier();

Expand Down