Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Token Type Utility Analyzer: Avoid allocations #6785

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make IterateTrivia static local function
  • Loading branch information
martin-strecker-sonarsource committed Feb 27, 2023
commit c5e8b1da55700af5ad01f2a13fea0847516e7461
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,15 @@ protected sealed override TokenTypeInfo CreateMessage(SyntaxTree syntaxTree, Sem
{
if (token.HasLeadingTrivia)
{
IterateTrivia(token.LeadingTrivia);
IterateTrivia(triviaClassifier, spans, token.LeadingTrivia);
}
if (tokenClassifier.ClassifyToken(token) is { } tokenClassification)
{
spans.Add(tokenClassification);
}
if (token.HasTrailingTrivia)
{
IterateTrivia(token.TrailingTrivia);
IterateTrivia(triviaClassifier, spans, token.TrailingTrivia);
}
}

Expand All @@ -74,7 +74,7 @@ protected sealed override TokenTypeInfo CreateMessage(SyntaxTree syntaxTree, Sem
tokenTypeInfo.TokenInfo.AddRange(spans);
return tokenTypeInfo;

void IterateTrivia(SyntaxTriviaList triviaList)
static void IterateTrivia(TriviaClassifierBase triviaClassifier, List<TokenTypeInfo.Types.TokenInfo> spans, SyntaxTriviaList triviaList)
{
foreach (var trivia in triviaList)
{
Expand Down