Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RspecStrings.resx #5851

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Remove RspecStrings.resx #5851

merged 2 commits into from
Jul 15, 2022

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented Jul 15, 2022 •
edited
Loading

Killing final boss after #5590

@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the base branch from master to Pavel/RSPEC-Builder July 15, 2022 11:34
csaba-sagi-sonarsource
csaba-sagi-sonarsource approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from Pavel/RSPEC-Builder to master July 15, 2022 14:23
@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review July 15, 2022 14:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 7f89677 into master Jul 15, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/RSPEC-RemoveResx branch July 15, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource approved these changes

Assignees

@pavel-mikula-sonarsource pavel-mikula-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavel-mikula-sonarsource @csaba-sagi-sonarsource