Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated RulesDefinitionXmlLoader #5590

Closed
pavel-mikula-sonarsource opened this issue Apr 25, 2022 · 0 comments · Fixed by #5838
Closed

Remove use of deprecated RulesDefinitionXmlLoader #5590

pavel-mikula-sonarsource opened this issue Apr 25, 2022 · 0 comments · Fixed by #5838
Assignees
Labels
Area: SQ Plugin Java plugin related issues.
Milestone

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Apr 25, 2022

We generate rules.xml file with rule descriptions that is imported by RulesDefinitionXmlLoader on the SQ plugin side.

The only useful information that the file contains is a list of parameters of the rules. The rest can be read directly from the JSON files.

We should simplify rules.xml to contain only that. And consider moving to json instead.

We should not depend on RulesDefinitionXmlLoader, as it is deprecated by SQ, see SONAR-14908.

Data flow before:

rspec files -> rspec script -> Analyzer resx --+-> Utilities -> RuleDescriptorGenerator -> rules.xml -> Java plugin
Rule parameters from reflection --------------´

Data flow after:

rspec files ---------------------------------------------------------------------+-> Java plugin
Rule parameters from reflection -> RuleDescriptorGenerator -> parameters.json --´
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Remove use of RulesDefinitionXmlLoader Remove use of deprecated RulesDefinitionXmlLoader Apr 25, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 8.42 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SQ Plugin Java plugin related issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants