Implement S4060 - Avoid unsealed attributes - for VB.NET #5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corniel
force-pushed
the
S4060-unsealed-attributes
branch
from
8eddaa9 to
7e7614e
Compare
Corniel
force-pushed
the
S4060-unsealed-attributes
branch
from
7e7614e to
805b6ac
Compare
|
@Corniel can you please rebase all your PRs on master? To remove the |
|
I've pushed a rspec scaffolding commit here. Please pull it before rebase 😃 |
Corniel
force-pushed
the
S4060-unsealed-attributes
branch
from
59f5525 to
8ca0a74
Compare
|
Rebase done. |
Corniel
commented
Jul 28, 2022
pavel-mikula-sonarsource
requested changes
Jul 28, 2022
analyzers/src/SonarAnalyzer.Common/Rules/AvoidUnsealedAttributesBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/AvoidUnsealedAttributesBase.cs
Outdated
Show resolved
Hide resolved
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…esBase.cs Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
…esBase.cs Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/AvoidUnsealedAttributes.vb
Outdated
Show resolved
Hide resolved
…Attributes.vb Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
July 28, 2022 11:49
… S4060-unsealed-attributes
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #501
Fixes #5930