Implement S4060 - Avoid unsealed attributes - for VB.NET

[pavel-mikula-sonarsource]

See S4060

Description

The .NET framework class library provides methods for retrieving custom attributes. Sealing the attribute eliminates the search through the inheritance hierarchy, and can improve performance.

This rule raises an issue when a public type inherits from System.Attribute, is not abstract, and is not sealed.

Noncompliant Code Example

Namespace MyLibrary 

    <AttributeUsage(AttributeTargets.Class)>
    Public Class MyAttribute ' Noncompliant
        Inherits Attribute 
    
        Public Sub New(name as String) 
            Value = val
        End Sub
        
        Public Readonly Property Value as String
    End Class
End Namespace

Compliant Solution

Namespace MyLibrary 

    <AttributeUsage(AttributeTargets.Class)>
    Public MustInherit Class MyAttribute ' Noncompliant
        Inherits Attribute 
    
        Public Sub New(val as String) 
            Value = val 
        End Sub
        
        Public Readonly Property Value as String
    End Class
End Namespace

[pavel-mikula-sonarsource]

Implemented in #5728