Rule S4035: Classes implementing "IEquatable<T>" should be sealed #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2017 11:06
michalb-sonar
suggested changes
Jun 22, 2017
| @@ -2233,7 +2233,7 @@ | |||
| <value>misra,cert</value> | |||
| </data> | |||
| <data name="S2201_Title" xml:space="preserve"> | |||
| <value>Return values from functions without side effects should not be ignored</value> | |||
| <value>Return values should not be ignored when function calls don't have any side effects</value> | |||
There was a problem hiding this comment.
Remove from this change, or move to a separate commit.
| namedTypeSymbol.TypeArguments.Length == 1; | ||
| } | ||
|
|
||
| private static bool IsValidEqualsMethodSymbol(IMethodSymbol methodSymbol) |
There was a problem hiding this comment.
It's not clear what exactly "valid" means. Perhaps rename the method to make it more obvious?
| foreach (var iequatable in equatableInterfacesByTypeName) | ||
| { | ||
| var associatedMethod = equalsMethodsByTypeName.GetValueOrDefault(iequatable.Key); | ||
| if (associatedMethod == null || |
There was a problem hiding this comment.
If both conditions are short, I'd move them to one line.
It's a minor style comment, feel free to ignore.
| methodSymbol.Parameters.Length == 1; | ||
| } | ||
|
|
||
| private static bool HasInvalidCombination(INamedTypeSymbol classSymbol) |
There was a problem hiding this comment.
Similar to above - could the method name give a hint on what invalid combination is?
| var equatableInterfacesByTypeName = classSymbol.AllInterfaces | ||
| .Where(IsValidEquatableInterfaceSymbol) | ||
| .ToDictionary(nts => nts.TypeArguments[0].Name, nts => nts); | ||
| var equalsMethodsByTypeName = classSymbol.GetMembers(EqualsMethodName) |
There was a problem hiding this comment.
New line here would make it more readable IMHO.
|
|
||
| // For all Equals(T) not a IEquatable<T> implementation checks if any is non-virtual | ||
| var unprocessedTypeNames = equalsMethodsByTypeName.Keys.Except(equatableInterfacesByTypeName.Keys); | ||
| foreach (var typeName in unprocessedTypeNames) |
There was a problem hiding this comment.
Perhaps rewrite with linq?
return unprocessedTypeNames.Any(typeName => equalsMethodsByTypeName[typeName].IsVirtual);
mary-georgiou-sonarsource
added a commit
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #461