Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S4035: Classes implementing "IEquatable<T>" should be sealed #461

Closed
Evangelink opened this issue Jun 21, 2017 · 0 comments
Closed

Rule S4035: Classes implementing "IEquatable<T>" should be sealed #461

Evangelink opened this issue Jun 21, 2017 · 0 comments
Assignees
@Evangelink
Milestone
6.1

Comments

@Evangelink
Copy link
Contributor

Evangelink commented Jun 21, 2017 •
edited
Loading

RSPEC-4035

When a class implements the IEquatable<T> interface, it enters a contract that, in effect, states "I know how to compare two instances of type T or any type derived from T for equality.". However if that class is derived, it is very unlikely that the base class will know how to make a meaningful comparison. Therefore that implicit contract is now broken.
@Evangelink Evangelink mentioned this issue Jun 21, 2017
Closed
@Evangelink Evangelink added this to the 6.1 milestone Jun 21, 2017
@Evangelink Evangelink self-assigned this Jun 21, 2017
@Evangelink Evangelink mentioned this issue Jun 22, 2017
Merged
@Corniel Corniel mentioned this issue Mar 6, 2019
Closed
mary-georgiou-sonarsource pushed a commit that referenced this issue Nov 28, 2024
@alex-meseldzija-sonarsource @gregory-paidis-sonarsource @mary-georgiou-sonarsource
NET-685 S6418 Implement Equals Capability (#461)
347297b 
Co-authored-by: Gregory Paidis <[email protected]>
hashicorp-vault-sonar-prod bot pushed a commit that referenced this issue Nov 29, 2024
@alex-meseldzija-sonarsource @gregory-paidis-sonarsource
NET-685 S6418 Implement Equals Capability (#461)
84c91a6 
Co-authored-by: Gregory Paidis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
None yet
Projects
None yet
Milestone
6.1
Development

No branches or pull requests
2 participants
@Evangelink @michalb-sonar