AI-638: FieldSet Component #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er/backpack-ios into chai/AI-638_field-set-component * 'chai/AI-638_field-set-component' of github.com:Skyscanner/backpack-ios: Updated snapshots
* main: AI-638: FieldSet Component (#2053) Add decision doc for accessibility identifiers in UI-tests (#2050) DON-591: Contribute Search Control Input component (#2038) Bump @babel/preset-env from 7.25.3 to 7.25.4 (#2051) Bump rexml from 3.3.3 to 3.3.6 (#2052) # Conflicts: # Backpack-SwiftUI/FieldSet/Classes/BPKFieldSet.swift # Backpack-SwiftUI/FieldSet/Classes/BPKFieldSetState.swift # Backpack-SwiftUI/FieldSet/README.md # Example/Backpack/SwiftUI/Components/FieldSet/FieldSetExampleView.swift
frugoman
reviewed
Aug 27, 2024
| @@ -51,11 +51,12 @@ extension View { | |||
| } | |||
|
|
|||
| public struct BPKSelect: View { | |||
| @Environment(\.bpkFieldSetState) var wrapperState | |||
There was a problem hiding this comment.
Suggested change
| @Environment(\.bpkFieldSetState) var wrapperState | |
| @Environment(\.bpkFieldSetState) var fieldSetState |
frugoman
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatch state updates using
.environmentinstead of calling the.updateState(). This gives consumers the flexibility to add view modifiers to the wrapped view.Remember to include the following changes:
README.mdBackpack.hheader fileIf you are curious about how we review, please read through the code review guidelines