AI-638: FieldSet Component #2053
Conversation
Snapshots were updated. Please verify the changes match the expected layout.
|
…er/backpack-ios into chai/AI-638_field-set-component * 'chai/AI-638_field-set-component' of github.com:Skyscanner/backpack-ios: Updated snapshots
|
|
||
| // swiftlint:disable closure_body_length | ||
| @ViewBuilder | ||
| private func constructViews(inErrorState: Bool) -> some View { |
There was a problem hiding this comment.
this code should not be here, it should be contained within the previows. here it's accessible from the component and that should not be the case.
you could create only one #preview and then assigne names to the 2 scroll views it'd have inside!
| import SwiftUI | ||
| import UIKit | ||
|
|
||
| public protocol BPKFieldSetStatusHandling: View { |
There was a problem hiding this comment.
minor: could you rename this protocol to be BPKFieldSetContentView?
| var body: some View { | ||
| ScrollView { | ||
| VStack(spacing: .md) { | ||
| Text("With Label & Description").fontWeight(.bold) |
There was a problem hiding this comment.
Could you change these to be BPKText?
| } | ||
| } | ||
|
|
||
| struct FieldSetExampleView_Previews: PreviewProvider { |
There was a problem hiding this comment.
you could use the new #preview macro instead
| VStack(alignment: .leading, spacing: .sm) { | ||
| labelView | ||
| content | ||
| .inputState(state) |
There was a problem hiding this comment.
I'm not quite sure I understand how this works? the implementations in the Text field, text area and BPKSelect just return mapping a state? but how is the style applied in the end I dont understand
There was a problem hiding this comment.
Just got it! it's calling each element's method!
| public func inputState(_ state: BPKFieldSet<BPKTextArea>.State) -> BPKTextArea { | ||
| switch state { | ||
| case .default: | ||
| return inputState(BPKTextArea.State.default) |
There was a problem hiding this comment.
is it calling itself? is this not an infinite loop?
There was a problem hiding this comment.
Ahh.. it's not calling itself, but the component's method, okay sorry!
* main: AI-638: FieldSet Component (#2053) Add decision doc for accessibility identifiers in UI-tests (#2050) DON-591: Contribute Search Control Input component (#2038) Bump @babel/preset-env from 7.25.3 to 7.25.4 (#2051) Bump rexml from 3.3.3 to 3.3.6 (#2052) # Conflicts: # Backpack-SwiftUI/FieldSet/Classes/BPKFieldSet.swift # Backpack-SwiftUI/FieldSet/Classes/BPKFieldSetState.swift # Backpack-SwiftUI/FieldSet/README.md # Example/Backpack/SwiftUI/Components/FieldSet/FieldSetExampleView.swift
Contribue BPKFieldSet component. Figma design.
Remember to include the following changes:
README.mdBackpack.hheader fileIf you are curious about how we review, please read through the code review guidelines