Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random Announcer System #415

Merged
merged 13 commits into from
Jul 12, 2024
Merged

Random Announcer System #415

merged 13 commits into from
Jul 12, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented May 19, 2024 •
edited
Loading

Description

Replaces every instance of station announcements with an announcer system meant to handle audio and messages for various announcers defined in prototypes instead of each server replacing the scattered files inconsistently with whatever singular thing they want to hear announce messages.

TODO

  • Systems
  • CVars
  • Sounds
  • Client volume slider
  • Collections
  • Prototypes
  • Events
  • Commands
  • PR media
  • Deglobalize
  • Passthrough localization parameters to overrides
  • Make every announcer follow the template
  • Move sounds into subdirectories
  • Make announcement IDs camelCased
  • Test announcement localizations
  • Weighted announcer lists

Media

2024-01-31_21-15-21.mp4

Changelog

🆑

  • add: Added 4 new announcers that will randomly be selected every shift

@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 3-Medium Needs to be resolved at some point Status: Do Not Merge Do not merge Size: 1-Very Large For especially large issues/PRs Type: Codebase An issue with the codebase Type: Feature Creation of or significant changes to a feature Type: Port Brings something to here from another codebase Type: Rework Large changes to a system, like a mix between the Balancing, Codebase, and Respace labels labels May 19, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT requested a review from a team May 19, 2024 23:42
@github-actions github-actions bot added Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Status: Needs Review Someone please review this labels May 19, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request May 19, 2024
Closed
16 tasks
@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Jun 3, 2024
Open
75 tasks
@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Jun 18, 2024
Open
8 tasks
@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review July 9, 2024 22:23
@VMSolidus

This comment was marked as resolved.

Sign in to view
VMSolidus
VMSolidus approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, go review Mass Contests now please.

@VMSolidus VMSolidus merged commit e3bc8d4 into Simple-Station:master Jul 12, 2024
11 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 12, 2024
@SimpleStation14
Automatic Changelog Update (#415)
69bf295
@FoxxoTrystan FoxxoTrystan mentioned this pull request Jul 15, 2024
Merged
VMSolidus added a commit to VMSolidus/Einstein-Engines that referenced this pull request Jul 16, 2024
@VMSolidus
Revert "Random Announcer System (Simple-Station#415)"
26c1aa1 
This reverts commit e3bc8d4.
@Peptide90 Peptide90 mentioned this pull request Jul 25, 2024
Open
2 tasks
@Darkmajia Darkmajia mentioned this pull request Aug 15, 2024
Merged
VMSolidus pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Aug 16, 2024
@RealFakeSoof @Aidenkrz @VMSolidus
#fixel (Simple-Station#415)
d139751 
* fixel

* Fuck the pixel up harder.

---------

Co-authored-by: Aidenkrz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@Peptide90 Peptide90 Awaiting requested review from Peptide90

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist

Assignees

@DEATHB4DEFEAT DEATHB4DEFEAT

Labels
Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 1-Very Large For especially large issues/PRs Status: Do Not Merge Do not merge Status: Needs Review Someone please review this Type: Codebase An issue with the codebase Type: Feature Creation of or significant changes to a feature Type: Port Brings something to here from another codebase Type: Rework Large changes to a system, like a mix between the Balancing, Codebase, and Respace labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DEATHB4DEFEAT @VMSolidus @DangerRevolution