-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsc-events-nextjs-256-archive-functionality #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome Ali, well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I tested this PR and it is working as far as archiving events on the frontend and making the proper changes to the data on the backend:
However, I am running into an issue with creating events now. When I create an event, it will not display on the home page. I tested main and it is working so I think it might have to do with some of the changes that were made to HomeEventGetter.tsx or UpcomingEvent.tsx components. @keiffer213
I'm experiencing the same thing as @taylorpapke. I am able to archive the event successfully, the event is hidden on the frontend, and the backend is updated. I didn't create new events, but I do have other events that I have had for a while and they are not displaying even when there are less than 5 events visible. I think the other events not showing up may have to do with what we talked about with BC last quarter: how the events being displayed are limited to 5 events, except the deleted and archived events are still in the database but hidden, so our other events including new ones won't show up. I could be wrong though. @cshimm This PR was just merged. Pull the changes in the backend and then try again. It might not been working for you because you were not running that PR on the backend at the same time with this PR. |
As Hanan said there's a 5 event limit thats fetched from the backend, when we call archive we're only hiding the event on the frontend and adding any more then 5 won't show on the frontend unless we delete any of the first 5 from the database. |
I got it working, thanks for the info @heosman |
@Ali-7s @taylorpapke Let's get this PR reviewed and merged, and then address the 5 event limit in another issue. I'll add it to the product backlog for now. |
PO would like to merge now and address the five event limit in another user story
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this review at the request of the product owner. The user story requirements are fulfilled with this pull request. The five event functionality will be addressed in the next sprint.
427d3620-e0cf-438d-9682-0ac4916f3b5a.mp4