nsc-events-nestjs-100-archive-event-functionality #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heosman
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Tested it on Postman and it's working, however, I noticed you used POST for the archive function's HTTP method. Because something is being updated when the API endpoint is called, rather than created (isArchived being updated from false to true), I think the PATCH or PUT method is better suited for our needs. For reference, Belinda's Closet is using PUT for their archive API endpoint.
Ali-7s
requested review from
heosman,
Seiyaroo,
NahomAlemu,
krayzieeddi,
tinpham5614,
TuongPhamM,
a team,
bcko and
Exochos
and removed request for
a team
taylorpapke
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Looks good now. Thanks for changing post to put. @keiffer213
heosman
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #100
7b9a13a8-b168-42de-8726-73ecfed79fb5.mp4