Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsc-events-nestjs-6-110-remove-duplicate-GET-handler #111

Merged
merged 3 commits into from
May 10, 2024
Merged

nsc-events-nestjs-6-110-remove-duplicate-GET-handler #111

merged 3 commits into from
May 10, 2024

Conversation

cshimm
Copy link
Contributor

@cshimm cshimm commented May 3, 2024 •
edited
Loading

Relates to #110

A duplicate GET('') handler was left in after PR #109, causing the correct GET('') handler with the numEvents query parameter to be ignored.

Also updates ActivityController tests to handle new route.

@cshimm cshimm added the bug Something isn't working label May 3, 2024
@cshimm cshimm self-assigned this May 3, 2024
@cshimm cshimm linked an issue May 3, 2024 that may be closed by this pull request
BUG: Remove duplicate GET('') handler #110
Closed
@cshimm cshimm marked this pull request as ready for review May 5, 2024 00:36
@cshimm cshimm requested review from Ali-7s, bennettsf, IsaacJrTypes, nwm516, a team, bcko, Exochos, Seiyaroo, tinpham5614, heosman, brinkbrink and taylorpapke and removed request for a team May 5, 2024 00:37
taylorpapke
taylorpapke approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be working properly when I run the code. Tests are also passing:
Screenshot 2024-05-05 at 2 02 55 PM

IsaacJrTypes
IsaacJrTypes approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@IsaacJrTypes IsaacJrTypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended. Had no issues with post man. The added test passed on my end as well.
CleanShot 2024-05-06 at 14 56 04@2x

@cshimm cshimm mentioned this pull request May 10, 2024
Merged
heosman
heosman approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@heosman heosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get all activities endpoint is working properly when I tested in Postman. Also, the added tests for the ActivityController passed.

image image

intisarosman1
intisarosman1 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@intisarosman1 intisarosman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests run perfectly with no problems and everything works on Postman too.
Screenshot 2024-05-10 080417
Screenshot 2024-05-10 081031

@taylorpapke taylorpapke merged commit 5d11786 into main May 10, 2024
3 checks passed
@taylorpapke taylorpapke deleted the bug-110-remove-duplicate-get-handler branch May 10, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacJrTypes IsaacJrTypes IsaacJrTypes approved these changes

@heosman heosman heosman approved these changes

@intisarosman1 intisarosman1 intisarosman1 approved these changes

@taylorpapke taylorpapke taylorpapke approved these changes

@Ali-7s Ali-7s Awaiting requested review from Ali-7s

@bennettsf bennettsf Awaiting requested review from bennettsf

@nwm516 nwm516 Awaiting requested review from nwm516

@bcko bcko Awaiting requested review from bcko bcko was automatically assigned from SeattleColleges/leadership

@Exochos Exochos Awaiting requested review from Exochos Exochos was automatically assigned from SeattleColleges/leadership

@Seiyaroo Seiyaroo Awaiting requested review from Seiyaroo Seiyaroo was automatically assigned from SeattleColleges/leadership

@tinpham5614 tinpham5614 Awaiting requested review from tinpham5614 tinpham5614 was automatically assigned from SeattleColleges/leadership

@brinkbrink brinkbrink Awaiting requested review from brinkbrink brinkbrink was automatically assigned from SeattleColleges/leadership

Assignees

@cshimm cshimm

Labels
bug Something isn't working
Projects
NSC Events
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Remove duplicate GET('') handler
5 participants
@cshimm @IsaacJrTypes @heosman @intisarosman1 @taylorpapke