Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Remove duplicate GET('') handler #110

Closed
cshimm opened this issue May 3, 2024 · 0 comments · Fixed by #111
Closed

BUG: Remove duplicate GET('') handler #110

cshimm opened this issue May 3, 2024 · 0 comments · Fixed by #111
Assignees
@cshimm
Labels
bug Something isn't working Sprint 6

Comments

@cshimm
Copy link
Contributor

cshimm commented May 3, 2024 •
edited
Loading

Relates to #109
A duplicate GET('') handler was left in the activity.controllers.ts file from Pull Request #109. This results in the correct handler with the numEvents param being ignored resulting in the default 5 events always returned, even with a different numEvents parameter passed in.

image

Since both of the paths are GET(' '), the first one is hit and the second one (the one with the numEvents param) is ignored.

Proposed resolution: Remove the first handler and rename the remaining handler to match the first.
image
@cshimm cshimm added bug Something isn't working Sprint 6 labels May 3, 2024
@cshimm cshimm self-assigned this May 3, 2024
@cshimm cshimm added this to NSC Events May 3, 2024
@cshimm cshimm changed the title BUG: Remove duplicate getAllActivities controller BUG: Remove duplicate GET('/') handler May 3, 2024
@cshimm cshimm changed the title BUG: Remove duplicate GET('/') handler BUG: Remove duplicate GET('') handler May 3, 2024
@cshimm cshimm mentioned this issue May 3, 2024
Merged
@cshimm cshimm linked a pull request May 3, 2024 that will close this issue
nsc-events-nestjs-6-110-remove-duplicate-GET-handler #111
Merged
@cshimm cshimm mentioned this issue May 6, 2024
Merged
@heosman heosman moved this from Todo to In Progress in NSC Events May 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in NSC Events May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cshimm cshimm

Labels
bug Something isn't working Sprint 6
Projects
NSC Events
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nsc-events-nestjs-6-110-remove-duplicate-GET-handler SeattleColleges/nsc-events-nestjs
1 participant
@cshimm