Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin sphinx #5901

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Unpin sphinx #5901

merged 5 commits into from
Apr 4, 2024

Conversation

tkknight
Copy link
Contributor

@tkknight tkknight commented Apr 3, 2024

🚀 Pull Request

Description

Changes to allow unpinning the sphinx dependency.

The build doc (local and on RTD) now uses the latest version of sphinx, currently 7.2.6 (version shown at the footer of the build html documentation).

The voted issue list is loaded correctly too - it was not before this change if you unpinned sphinx.

Closes #5123.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

* upstream/main: (163 commits)
  Restore latest Whats New files.
  Whats new updates for `v3.9.0rc0` (SciTools#5899)
  nep29: drop py39 and support py312 (SciTools#5894)
  Support NetCDF v3 files in chunking control code. (SciTools#5897)
  Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896)
  Force pytest colour output on GitHub Actions (SciTools#5895)
  Make typing 3.9 compatible.
  Improve typing readability.
  Updated environment lockfiles (SciTools#5892)
  [pre-commit.ci] pre-commit autoupdate
  What's New entry for SciTools#5740 .
  Iris to GeoVista conversion (SciTools#5740)
  Try Union for type hinting.
  Type hinting.
  Fix typo.
  Re-introduce backwards compatible warning.
  Updated documentation.
  Remove loose references to fill value warnings.
  Advertise structured_um_loading performance regression.
  [pre-commit.ci] pre-commit autoupdate
  ...
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (7c313ff) to head (b06ca1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5901   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          93       93           
  Lines       22982    22982           
  Branches     5006     5006           
=======================================
  Hits        20630    20630           
  Misses       1622     1622           
  Partials      730      730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkknight tkknight marked this pull request as ready for review April 4, 2024 09:41
@bjlittle bjlittle self-assigned this Apr 4, 2024
@bjlittle bjlittle self-requested a review April 4, 2024 13:43
@bjlittle bjlittle self-requested a review April 4, 2024 13:46
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight LGTM 👍

Fancy adding a whatsnew entry?

tkknight added 2 commits April 4, 2024 15:13
* upstream/main:
  DOC: clarify save_pairs_from_cube docstring (SciTools#5783)
@bjlittle bjlittle merged commit 212ef56 into SciTools:main Apr 4, 2024
20 checks passed
@tkknight tkknight deleted the unpin_sphinx branch April 4, 2024 14:32
tkknight added a commit to tkknight/iris that referenced this pull request Apr 10, 2024
…th_numpydoc

* upstream/main: (39 commits)
  Bump scitools/workflows from 2024.03.3 to 2024.04.0 (SciTools#5907)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5906)
  Updated environment lockfiles (SciTools#5904)
  Ignore flaticon.com in linkchecks. (SciTools#5905)
  Implement lazy area weights (SciTools#5658)
  Add option to specify chunks in `iris.util.broadcast_to_shape` (SciTools#5620)
  Unpin sphinx (SciTools#5901)
  DOC: clarify save_pairs_from_cube docstring (SciTools#5783)
  Restore latest Whats New files.
  Whats new updates for `v3.9.0rc0` (SciTools#5899)
  nep29: drop py39 and support py312 (SciTools#5894)
  Support NetCDF v3 files in chunking control code. (SciTools#5897)
  Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896)
  Force pytest colour output on GitHub Actions (SciTools#5895)
  Make typing 3.9 compatible.
  Improve typing readability.
  Updated environment lockfiles (SciTools#5892)
  [pre-commit.ci] pre-commit autoupdate
  What's New entry for SciTools#5740 .
  Iris to GeoVista conversion (SciTools#5740)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCS: Remove sphinx temporary maximum pin
2 participants