Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Remove sphinx temporary maximum pin #5123

Closed
bjlittle opened this issue Jan 3, 2023 · 1 comment · Fixed by #5901
Closed

DOCS: Remove sphinx temporary maximum pin #5123

bjlittle opened this issue Jan 3, 2023 · 1 comment · Fixed by #5901

Comments

@bjlittle
Copy link
Member

bjlittle commented Jan 3, 2023

📰 Custom Issue

Remove the temporary maximum pip pin sphinx<5 introduced into the setup.py by #5122

@tkknight
Copy link
Contributor

tkknight commented Nov 9, 2023

Tested an unpin of sphinx 09/11/23.

The docs built without error with sphinx 7.2.6 locally and on readthedocs (currently pinned to 5.3). The only issue I have found is that the voted issues table (via datatables.net) fails to render, pressing F12 in the web browser shows the errors:

image

I am unable to fix this at present. We can either wait a bit longer to see if a future update fixes this or we could look to remove the voted tables use of datatables and just link directly to github (which now allows sorting by reactions).

@scitools-ci scitools-ci bot removed this from 🚴 Peloton Dec 15, 2023
@tkknight tkknight changed the title Remove sphinx temporary maximum pin DOCS: Remove sphinx temporary maximum pin Jan 11, 2024
@tkknight tkknight mentioned this issue Apr 4, 2024
@scitools-ci scitools-ci bot removed this from 🚴 Peloton May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants