Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files #104

Merged
merged 4 commits into from
May 21, 2018
+2 −2
Merged

Update files #104

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8db681e
no longer needed
ocefpaf May 21, 2018
11a48de
ensure pxd and pyx are in the source tarball
ocefpaf May 21, 2018
f55523d
update manifest file
ocefpaf May 21, 2018
463b2f4
review actions
ocefpaf May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
include *.rst
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm counting on #103 for this change 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, it will need to be replaced with *.md...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. You have write access on this repo @ocefpaf. Why count on it, and not feel free to just merge 😜.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do for simpler things, but it turns out I needed a review on this one after all.

include *.txt
recursive-include cf_units *.py
include cf_units/etc/site.cfg.template
include cf_units/etc/_udunits2.pxd
Copy link
Member

@pelson pelson May 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etc?

Could you simply remove these lines and update the recursive include:

recursive-include cf_units *.py *.pxd *.pyx

include cf_units/etc/_udunits2.pyx
include CHANGES COPYING COPYING.LESSER INSTALL
include versioneer.py
exclude cf_units/etc/site.cfg
2 changes: 0 additions & 2 deletions cf_units/etc/site.cfg.template
View file
Open in desktop

This file was deleted.