-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update files #104
Update files #104
Conversation
@@ -1,7 +1,6 @@ | |||
include *.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm counting on #103 for this change 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though, it will need to be replaced with *.md
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. You have write access on this repo @ocefpaf. Why count on it, and not feel free to just merge 😜.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do for simpler things, but it turns out I needed a review on this one after all.
cf_units/etc/site.cfg.template
Outdated
@@ -1,2 +0,0 @@ | |||
[System] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, this is still valid (XML file, not .so
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, yep! (I guess I need to fix our conda recipe too.)
MANIFEST.in
Outdated
include *.txt | ||
recursive-include cf_units *.py | ||
include cf_units/etc/site.cfg.template | ||
include cf_units/etc/_udunits2.pxd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
etc?
Could you simply remove these lines and update the recursive include:
recursive-include cf_units *.py *.pxd *.pyx
I've fixed this locally with:
(tested and 👍) |
Excellent! Thanks @ocefpaf. |
I thinks this should fix the source tarball. See conda-forge/cf_units-feedstock#14 for the failures we are getting with the latest PyPI tarball.