Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some errors found while testing the new sdk release and bump sdk to latest version #1681

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Dec 4, 2024

Description

Fix errors in dataset property access by removing unnecessary string indexing and update to use dot notation. Bump @scicatproject/scicat-sdk-ts dependency to version 4.8.3.

Bug Fixes:

  • Fix errors in dataset property access by removing unnecessary string indexing.

Enhancements:

  • Update dataset property access to use dot notation for improved readability.

Build:

  • Bump @scicatproject/scicat-sdk-ts dependency to version 4.8.3 in package.json.

Fixes:

Please provide a list of the fixes implemented in this PR

  • Issues found while testing in dev environment

@martin-trajanovski martin-trajanovski marked this pull request as ready for review December 5, 2024 15:46
@martin-trajanovski martin-trajanovski changed the title fix: fix some errors and bump sdk to latest version fix: fix some errors found while testing the new sdk release and bump sdk to latest version Dec 5, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martin-trajanovski - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more specific details about the issues that were found during testing in the dev environment. This helps with tracking and understanding the history of changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martin-trajanovski martin-trajanovski merged commit 3b813bc into master Dec 5, 2024
6 checks passed
@martin-trajanovski martin-trajanovski deleted the fixes-after-new-sdk-release branch December 5, 2024 18:31
sofyalaski pushed a commit to sofyalaski/frontend that referenced this pull request Dec 17, 2024
@martin-trajanovski martin-trajanovski added DCS DAPHNE Contribution to SciCat Improvement labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants