fix: fix some errors and bump sdk to latest version (#1681)

SciCatProject · Dec 5, 2024 · 3b813bc · 3b813bc
1 parent ab8a166
commit 3b813bc
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
     "@ngrx/effects": "^16",
     "@ngrx/router-store": "^16",
     "@ngrx/store": "^16",
-    "@scicatproject/scicat-sdk-ts": "^4.7.2",
+    "@scicatproject/scicat-sdk-ts": "^4.8.3",
     "autolinker": "^4.0.0",
     "deep-equal": "^2.0.5",
     "exceljs": "^4.3.0",

diff --git a/src/app/datasets/dataset-details-dashboard/dataset-details-dashboard.component.ts b/src/app/datasets/dataset-details-dashboard/dataset-details-dashboard.component.ts
@@ -260,27 +260,24 @@ export class DatasetDetailsDashboardComponent
 
   fetchDatasetRelatedDocuments(): void {
     if (this.dataset) {
-      if ("proposalId" in this.dataset && this.dataset["proposalId"] !== "") {
+      if ("proposalId" in this.dataset && this.dataset.proposalId) {
         this.store.dispatch(
           fetchProposalAction({
-            proposalId: this.dataset["proposalId"] as string,
+            proposalId: this.dataset.proposalId,
           }),
         );
       } else {
         this.store.dispatch(clearLogbookAction());
       }
-      if ("sampleId" in this.dataset && this.dataset["sampleId"] !== "") {
+      if ("sampleId" in this.dataset && this.dataset.sampleId) {
         this.store.dispatch(
-          fetchSampleAction({ sampleId: this.dataset["sampleId"] as string }),
+          fetchSampleAction({ sampleId: this.dataset.sampleId }),
         );
       }
-      if (
-        "instrumentId" in this.dataset &&
-        this.dataset["instrumentId"] !== ""
-      ) {
+      if ("instrumentId" in this.dataset && this.dataset.instrumentId) {
         this.store.dispatch(
           fetchInstrumentAction({
-            pid: this.dataset["instrumentId"] as string,
+            pid: this.dataset.instrumentId,
           }),
         );
       }