Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔀 :: [#75] 로그인 버튼 API 연결 #88
🔀 :: [#75] 로그인 버튼 API 연결 #88
Changes from 37 commits
23a0e1f
56d9d24
25bb171
4266794
6eae329
3ed2532
33287e9
e64e1db
f5d5d80
f28f799
ce1c3ba
b690c8d
d02fc09
b1c7b22
6c06727
9a28740
cbffd75
40270b0
11cf7ee
53567d3
9071408
dc8332e
979b7c5
069c10e
c476b43
5b360a3
291113e
6015160
258643e
97f55aa
de9570b
ab3dc2c
0fb5c4c
d199f2a
2fbd06e
cc98091
294df6a
93b1593
08c198d
31b94ed
121e069
bcbad7e
ac3f167
4b73952
cf13b32
225baa6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 BaseFeature에 있는건 좀 어색한거같네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RootFeature의 Extensions으로 빼봤는데 어떤가요...?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature에 있는거 자체가 좀 별로인거같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그럼 어디에 있는 게 좋을까요ㅠㅠ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Utils/Extensions/View/View+eraseToAnyView.swift
이런식으로 빼거나 더 레이어 높이려면
Shared/Utils/Extensions/View/View+eraseToAnyView.swift
로 하는게 괜찮을거같네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했어요!
cf13b32