🔀 :: [#75] 로그인 버튼 API 연결 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuuunseo
requested review from
baekteun,
shwaaaa,
hanjaehyeong and
kimkyumbi
Closed
… 75-connect_auth_api
|
연동이 성공 실패만 print하고 뭐 없나요 |
baekteun
reviewed
Nov 27, 2023
baekteun
reviewed
Nov 27, 2023
Comment on lines
11
to
25
| var remoteAuthDataSource: RemoteAuthDataSource { | ||
| shared { | ||
| RemoteAuthDataSource(keychian: keychain) | ||
| } | ||
| } | ||
|
|
||
| var authRepository: any AuthRepository { | ||
| shared { | ||
| AuthRepositoryImpl( | ||
| remoteAuthDataSource: remoteAuthDataSource, | ||
| localAuthDataSource: localAuthDataSource | ||
| ) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
프로토콜 타입 명시에 any가 붙은곳도 있고 아닌곳도있는데 일관성 맞춰주면 좋겠네용
baekteun
reviewed
Nov 27, 2023
baekteun
reviewed
Nov 27, 2023
uuuunseo
force-pushed
the
75-connect_auth_api
branch
from
6673e45 to
0fb5c4c
Compare
baekteun
reviewed
Nov 28, 2023
baekteun
reviewed
Nov 28, 2023
baekteun
reviewed
Nov 28, 2023
넵!! 다음부터는 쪼개서 작업해보겠습니다!! |
baekteun
reviewed
Nov 28, 2023
Co-authored-by: baegteun <[email protected]>
…ouel-iOS into 75-connect_auth_api
baekteun
reviewed
Dec 2, 2023
There was a problem hiding this comment.
이거 BaseFeature에 있는건 좀 어색한거같네요
There was a problem hiding this comment.
RootFeature의 Extensions으로 빼봤는데 어떤가요...?!
There was a problem hiding this comment.
Feature에 있는거 자체가 좀 별로인거같아요
There was a problem hiding this comment.
그럼 어디에 있는 게 좋을까요ㅠㅠ?
There was a problem hiding this comment.
Utils/Extensions/View/View+eraseToAnyView.swift
이런식으로 빼거나 더 레이어 높이려면
Shared/Utils/Extensions/View/View+eraseToAnyView.swift
로 하는게 괜찮을거같네요
baekteun
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
로그인 버튼 API 연결
📃 작업내용
로그인 버튼을 LoginUseCase와 연결했습니다.