Crhodes/rpm spec #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquerna
reviewed
Dec 21, 2017
dist/rpm/libxjwt.spec
Outdated
|
|
||
| %install | ||
| cd libxjwt-%{version} | ||
| scons install --install-sandbox="$RPM_BUILD_ROOT" |
There was a problem hiding this comment.
should we just add --prefix=/usr here, and then we can drop all of the ld.so.conf.d dance? Seems like the most "normal" for an RPM to prefix in /usr?
pquerna
reviewed
Dec 21, 2017
dist/rpm/libxjwt.spec
Outdated
| cd %{name}-%{version} | ||
| scons install --install-sandbox="$RPM_BUILD_ROOT" prefix=/usr | ||
|
|
||
| %post -p /sbin/ldconfig |
There was a problem hiding this comment.
I think without this, scons will install to the root of the host and not the buildroot for the rpm.
Also, I dont think there's any other mechanism to have ldd pick up on the new module without that call there. I can try removing both of these though and see what happens.
arreyder
force-pushed
the
crhodes/rpm_spec
branch
from
13a425a to
9707d5d
Compare
pquerna
reviewed
Dec 21, 2017
dist/rpm/libxjwt.spec
Outdated
| URL: https://github.com/ScaleFT/libxjwt | ||
| Vendor: ScaleFT http://scaleft.com | ||
|
|
||
| BuildRequires: scons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a spec file suitable to building rpms for centos7.