2356 correct behaviour add all constraints #2728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalezma
added
Defect
|
Closing as branch merged with #2355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the behaviour of the Complex Constraint Add All button in the way that seems more logical/intuitive TO ME. All fittable (including polydisperse) parameters in two fitting pages are constrained, while the fixed parameters are ignored.
Previously one had the following:
And with the proposed change one gets:
Fixes # 2356
How Has This Been Tested?
Tested locally with two sets of data fitted by a core-shell model where radius and thickness are polydispersed and polydispersity is fittable, while the SLDs are different.
Review Checklist (please remove items if they don't apply):