Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add All button in Complex Constraint window does not work for polydisperse parameters #2356

Closed
gonzalezma opened this issue Oct 31, 2022 · 1 comment
Labels
Defect Bug or undesirable behaviour Fitting Perspective Concerns the fitting perspective

Comments

@gonzalezma
Copy link
Contributor

Describe the bug
The Complex Constrain interface allows setting automatically all the possible constraints between 2 FitPages. However, the polydisperse parameters are ignored.

To Reproduce
Steps to reproduce the behavior:

  1. Load 2 data sets and define a model that includes PD params.
  2. Go to the Constrained or Simultaneous Fit.
  3. In Add constraints, set M2.scale = M1.scale and then press Add All.
  4. See error:
    4.1 All the parameters of the model page are added to the list of constraints, e.g.:
    M2.scale = M1.scale
    M2.radius = M1.radius
    M2.thickness = M1.thickness
    BUT also non-fittable parameters (e.g. sld) are added to the list. This should probably be reconsidered.
    4.2 The PD parameters (e.g. radius.width) are not added, so they have to be included one by one.

Expected behavior
Only adjustable parameters should be added to the list of constraints when using the Add All button.
The adjustable PD params should also be added.

SasView version (please complete the following information):

  • SasView 5.0.6? Tested in ESS_GUI_constrain_branch to be merged, as before it was not even possible to define constraints for PD parameters.

Operating system (please complete the following information):

  • Windows 10
@lucas-wilkins lucas-wilkins added Defect Bug or undesirable behaviour Fitting Perspective Concerns the fitting perspective labels Oct 31, 2022
gonzalezma added a commit that referenced this issue Jan 17, 2024
@gonzalezma
Copy link
Contributor Author

Fixed by PR #2743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Fitting Perspective Concerns the fitting perspective
Projects
None yet
Development

No branches or pull requests

2 participants