Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing version number #1874

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fixing version number #1874

merged 2 commits into from
Jun 29, 2021

Conversation

wpotrzebowski
Copy link
Contributor

The previous proposal with 5.x.x-alpha1 didn't work with StrictVersion from distutils. The alternative is to use a1 label e.g. 5.0.5a1

@wpotrzebowski
Copy link
Contributor Author

ready for testing on OSX

@butlerpd
Copy link
Member

Does this mean that the dev nomenclature suggested in #1872 from PEP 440 not resolve properly?

@wpotrzebowski
Copy link
Contributor Author

ready for testing on Windows

@wpotrzebowski
Copy link
Contributor Author

ready for testing on Win

krzywon
krzywon requested changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the loading issue, but the docstrings need to match the functionality or someone might repeat this mistake in the future.

@krzywon krzywon mentioned this pull request Jun 21, 2021
Merged
@wpotrzebowski
Copy link
Contributor Author

ready for testing on OSX

@wpotrzebowski
Copy link
Contributor Author

ready for testing on Linux

@krzywon
Copy link
Contributor

krzywon commented Jun 23, 2021

I havent looked at why the builds are failing in this case, but everything here looks good now.

@wpotrzebowski
Copy link
Contributor Author

I havent looked at why the builds are failing in this case, but everything here looks good now.

Yes, builds are still failing. I am trying to look into this.

@wpotrzebowski wpotrzebowski merged commit 037e09e into main Jun 29, 2021
@wpotrzebowski wpotrzebowski deleted the version_fix branch June 29, 2021 20:54
@butlerpd butlerpd mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzywon krzywon krzywon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpotrzebowski @butlerpd @krzywon