You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
StrictVersion() call on the new format version string 5.0.5-alpha.1 seems to confuse distutils.version.StrictVersion() check with default versioning of distutils (3.6.13)
Attempting to start SasView on either Linux or Windows fails with
ValueError: invalid version number '5.0.5-alpha.1'
The text was updated successfully, but these errors were encountered:
Interesting --- I had forgotten we do use the version number for one thing besides printing the string in various places: "checking whether I am the latest version." I guess that is where we are using StrictVersion rather than LooseVersion?
As I understand it, PEP 440 covers StrictVersion? If so I note that besides a, b and rc (instead of alpha, beta etc,) a dev and post tags are also allowed? Given the rationale for adding the tag after a release, the dev tag may be more appropriate than a(lpha). From what I can tell we should avoid using the post tag. So, my suggestions is that we replace the original suggestion of using alpha for nightly builds with dev. Thus immediately upon release of 5.0.4 for example, the version should be incremented to: 5.0.5dev1
It may also be appropriate in the init.py to add a comment indicating strict versioning only.
Of course the above proposal assumes that dev resolves as preceding a which precedes b which precedes rc. It should based on the description but {a,b,rc} follow the natural lexical order but dev would not so we should probably check this before adopting it.
StrictVersion() call on the new format version string
5.0.5-alpha.1
seems to confuse distutils.version.StrictVersion() check with default versioning of distutils (3.6.13)Attempting to start SasView on either Linux or Windows fails with
The text was updated successfully, but these errors were encountered: