Correct timing when GI is added #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this
ghost
reopened this
ghost
commented
Feb 4, 2019
| @@ -162,7 +162,7 @@ float4 frag_forward(v2f i) : SV_TARGET | |||
| half4 shade = _ShadeColor * tex2D(_ShadeTexture, mainUv); | |||
| half4 lit = _Color * mainTex; | |||
| half3 col = lerp(shade.rgb, lit.rgb, lightIntensity); | |||
| col *= lighting; | |||
| col = col * lighting + indirectLighting * lit; | |||
There was a problem hiding this comment.
DirectionalLightの影響を受けないように、IndirectLightはlitをサンプルするように変更しました
従来の挙動ではDirectionalLightの影響を受けてしまいます
ghost
mentioned this pull request
|
遅れてすみません。 |
|
↑ も含めて 150 行目の宣言は 160 行目くらいに |
|
対応しました 👍 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題
設定例
実際の見た目
想定していた見た目
キャラクターの場合の参考画像
Lambert（リファレンス）
従来の挙動（GI Intencity = 1）
このPRでの挙動