-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Shudan 1.7.x #883
Conversation
Webpack 4 fails to parse the nullish coalescing operator '??' which Shudan 1.7.0 uses.
Hmm, so |
@yishn Do you have any insight here? It seems there's some sort of incompatibility with how imports are resolved. Ever since SabakiHQ/Shudan@966c924 Sabaki is translating's Shudan's Relevant stack trace:
|
I have removed the "preact" alias in |
Indeed, not sure how I missed that :) Though I wish I understood what it was about Thanks @yishn! |
I think the reason was the introduction of a |
This required an upgrade from Webpack 4 to Webpack 5 because Shudan 1.7.0 makes use of the nullish coalescing operator '??' which Webpack 4 fails to parse. Luckily, this was a pretty painless migration.
Closes #882.