Skip to content

Commit

Permalink
Upgrade to Shudan 1.7.x (#883)
Browse files Browse the repository at this point in the history
* Update to Webpack 5

Webpack 4 fails to parse the nullish coalescing operator '??' which
Shudan 1.7.0 uses.

* Bump Shudan 1.7.1

* Remove preact alias

Co-authored-by: Yichuan Shen <[email protected]>
  • Loading branch information
apetresc and yishn authored Aug 14, 2022
1 parent 39a027a commit 3ee67cd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"@sabaki/immutable-gametree": "^1.9.4",
"@sabaki/influence": "^1.2.2",
"@sabaki/sgf": "^3.4.7",
"@sabaki/shudan": "^1.5.4",
"@sabaki/shudan": "^1.7.1",
"argv-split": "^2.0.1",
"classnames": "^2.2.6",
"dolm": "^0.7.3-beta",
Expand All @@ -122,8 +122,8 @@
"prettier": "1.19.1",
"react": "^16.13.1",
"tmp": "^0.1.0",
"webpack": "^4.42.1",
"webpack-cli": "^3.3.11"
"webpack": "^5.74.0",
"webpack-cli": "^4.10.0"
},
"scripts": {
"test": "mocha --require esm",
Expand Down
6 changes: 1 addition & 5 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = (env, argv) => ({
path: __dirname
},

devtool: argv.mode === 'production' ? false : 'cheap-module-eval-source-map',
devtool: argv.mode === 'production' ? false : 'eval-cheap-module-source-map',
target: 'electron-renderer',

node: {
Expand All @@ -21,10 +21,6 @@ module.exports = (env, argv) => ({
argv.mode === 'production'
? path.join(__dirname, 'node_modules/preact/dist/preact.min.js')
: 'preact',
preact:
argv.mode === 'production'
? path.join(__dirname, 'node_modules/preact/dist/preact.min.js')
: 'preact',
'prop-types': path.join(__dirname, 'src/modules/shims/prop-types.js')
}
},
Expand Down

0 comments on commit 3ee67cd

Please sign in to comment.