Fix bug making upgrades always playable (#611)

Fixed #593 . We just didn't have a check in the path that enforced a
legal attach target

server/game/actions/PlayUpgradeAction.ts

@@ -52,6 +52,11 @@ export class PlayUpgradeAction extends PlayCardAction {
         ) {
             return 'restriction';
         }
+
+        if (!this.hasSomeLegalTarget(context)) {
+            return 'attachTarget';
+        }
+
         return super.meetsRequirements(context, ignoredRequirements);
     }
 

test/server/core/card/Upgrade.spec.ts

@@ -178,5 +178,19 @@ describe('Upgrade cards', function() {
                 expect(context.entrenched).toBeInZone('discard', context.player2);
             });
         });
+
+        it('When an upgrade is in hand and has no legal target, it should not be clickable', async function() {
+            await contextRef.setupTestAsync({
+                phase: 'action',
+                player1: {
+                    hand: ['academy-training', 'wampa'],
+                }
+            });
+
+            const { context } = contextRef;
+
+            expect(context.player1).not.toBeAbleToSelect(context.academyTraining);
+            expect(context.academyTraining).not.toHaveAvailableActionWhenClickedBy(context.player1);
+        });
     });
 });