Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with playing upgrades #593

Closed
AMMayberry1 opened this issue Feb 14, 2025 · 2 comments · Fixed by #611
Closed

Issues with playing upgrades #593

AMMayberry1 opened this issue Feb 14, 2025 · 2 comments · Fixed by #611
Assignees
@AMMayberry1
Labels
bug Something isn't working difficult-complexity high-priority

Comments

@AMMayberry1
Copy link
Collaborator

Upgrades seem to always appear as playable in hand, even if there is no legal unit to play them on. In addition, if you click them when there's no legal target, the resource will still get spent but the action is not expended and the card doesn't move anywhere.
@adbronico
Copy link
Collaborator

@AMMayberry1 should this wait til my Piloting work is done, or be done before that?

@AMMayberry1
Copy link
Collaborator Author

@adbronico I don't think there will be collisions, or if they are they should be easy to solve. Since this is a pretty bad issue for testing, I'm planning to prioritize it pretty high - I'm blocked on other stuff right now so I'm going to take and see how bad the issue is at least

@AMMayberry1 AMMayberry1 self-assigned this Feb 16, 2025
@AMMayberry1 AMMayberry1 mentioned this issue Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AMMayberry1 AMMayberry1

Labels
bug Something isn't working difficult-complexity high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug making upgrades always playable SWU-Karabast/forceteki
2 participants
@AMMayberry1 @adbronico