Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump hybrid-array from 0.2.0-rc.8 to 0.2.0-rc.9 #1435

Merged
merged 3 commits into from
Jun 25, 2024
Merged

chore(deps): bump hybrid-array from 0.2.0-rc.8 to 0.2.0-rc.9 #1435

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c1c339
chore(deps): bump hybrid-array from 0.2.0-rc.8 to 0.2.0-rc.9
dependabot[bot] Jun 24, 2024
7117a1b
sec1: Array conversions should not fail.
baloo Jun 24, 2024
17069e8
cms: Array conversions should not fail.
baloo Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 70 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sec1/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ rust-version = "1.72"
[dependencies]
base16ct = { version = "0.2", optional = true, default-features = false }
der = { version = "=0.8.0-pre.0", optional = true, features = ["oid"] }
hybrid-array = { version = "0.2.0-rc.8", optional = true, default-features = false }
hybrid-array = { version = "0.2.0-rc.9", optional = true, default-features = false }
pkcs8 = { version = "=0.11.0-pre.0", optional = true, default-features = false }
serdect = { version = "=0.3.0-pre.0", optional = true, default-features = false, features = ["alloc"] }
subtle = { version = "2", optional = true, default-features = false }
Expand Down
4 changes: 2 additions & 2 deletions sec1/src/point.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ where
}

let (x_bytes, y_bytes) = self.bytes[1..].split_at(Size::to_usize());
let x = Array::from_slice(x_bytes);
let x = x_bytes.try_into().expect("size invariants were violated");
Comment on lines 212 to +213
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we could add something to hybrid-array to help with this pattern, possibly an implementation of split_array. But this is fine for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, the API looks acceptable.


if self.is_compressed() {
Coordinates::Compressed {
Expand All @@ -222,7 +222,7 @@ where
} else {
Coordinates::Uncompressed {
x,
y: Array::from_slice(y_bytes),
y: y_bytes.try_into().expect("size invariants were violated"),
}
}
}
Expand Down
Loading