Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump hybrid-array from 0.2.0-rc.8 to 0.2.0-rc.9 #1435

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 24, 2024

Bumps hybrid-array from 0.2.0-rc.8 to 0.2.0-rc.9.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [hybrid-array](https://github.com/RustCrypto/hybrid-array) from 0.2.0-rc.8 to 0.2.0-rc.9.
- [Changelog](https://github.com/RustCrypto/hybrid-array/blob/master/CHANGELOG.md)
- [Commits](RustCrypto/hybrid-array@v0.2.0-rc.8...v0.2.0-rc.9)

---
updated-dependencies:
- dependency-name: hybrid-array
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jun 24, 2024
@baloo baloo force-pushed the dependabot/cargo/hybrid-array-0.2.0-rc.9 branch from 28ddab1 to 7117a1b Compare June 24, 2024 20:24
@tarcieri
Copy link
Member

Looks like clippy is complaining about some deprecations other crates aren't, oddly

Comment on lines 212 to +213
let (x_bytes, y_bytes) = self.bytes[1..].split_at(Size::to_usize());
let x = Array::from_slice(x_bytes);
let x = x_bytes.try_into().expect("size invariants were violated");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we could add something to hybrid-array to help with this pattern, possibly an implementation of split_array. But this is fine for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, the API looks acceptable.

@baloo baloo merged commit f2d0ab4 into master Jun 25, 2024
165 checks passed
@baloo baloo deleted the dependabot/cargo/hybrid-array-0.2.0-rc.9 branch June 25, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants