Issue #2298 unit tests #2469
Merged
Issue #2298 unit tests #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of these changes is that the code of related frontend modules should become more similar again. This makes it easier to spot divergences that are not intended. There could be fixed in one frontend that are relevant for other frontends too.
A recent addition is that helper subs like _Mask() and _MaskPhone() now get the additional parameter DFValues. But these helper subs are also called in the case of error, or when a form draft was loaded. In these instances the new parameter DFValues was missing. This patch should fix three test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.