-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dynamic field types: Reference and Lens #2298
Comments
This feature is based on the enhancements done for #2251. |
I noticed that dynamic fields types are declared in different XML files. This makes sense for specialized dynamic fields types, like the types used by process management. But it makes no sense that generally usable dynamic fields like Text or Multiselect are declared in Ticket.xml. |
Please make sure that the objects are actually linked to each other (so that you can scroll down to the link objects and reach them). |
No, they won't be linked via standard links. (We can think about an extension which does this later, but not currently.) |
As written before, the dynamic fields in Ticket.xml are the OTRS standard dynamic fields. The config of special dynamic fields like Webservices etc., which were added with OTOBO were written to a separate file. This is not consistent and can be improved, but it has no high priority either. |
The reference dynamic field needs object type specific plugins. For now there is only a plugin for Tickets.
Limit the scope of some variables.
Eliminate unused variable $Object. Work with %Data instead of $Data.
in the edit mask for the Reference dynamic field
enhance code comments reduce scope of some variables empty line before control flow use the defined or operator
for getting the referenced object ID and for getting the relevant config or the dynamic field that is lensed into
…et_type Issue #2298: Consider the TicketType
The ObjectType gives information what the passed ObjectID means. Currently this is only relevant for distinguishing between ITSMConfigItem and ITSMConfigItemVersion.
Issue #2298: pass the relevant ObjectType to ValueSet.
…s respect the reference object of the edit mask if applicable.
* Added possibility to define filter for reference fields. Added possibility to make generic config settings multiselect. * Added PossibleNone setting to dynamic field reference. * Removed Validate_Required class from df reference filter list. * Fixed reference field restrictions for AgentTicketPhone. * Adapted ajax update changes to other masks. * Added sysconfig to use dynamic field reference search in customer frontend. * Adapted reference filter changes to CustomerTicketProcess. Added ToDo comments. * Made autocomplete config usable in customer interface in reference driver. Fixed filtering for changed elements matches in reference filter list. * Adapt changes from config item reference field to ticket reference field. * Added some corrections to value passing in ticket modules.
The goal of these changes is that the code of related frontend modules should become more similar again. This makes it easier to spot divergences that are not intended. There could be fixed in one frontend that are relevant for other frontends too.
A recent addition is that helper subs like _Mask() and _MaskPhone() now get the additional parameter DFValues. But these helper subs are also called in the case of error, or when a form draft was loaded. In these instances the new parameter DFValues was missing. This patch should fix three test failures.
More developments took place in the mean time and new developments should have dedicated issues. So, closing this issue. |
Two new field types are deemed to be useful for OTOBO 11.0.x:
Reference
A dynamic field that references another entity, like Ticket, FAQ, or Configitem. Only entities supporting dynamic fields can be linked. The config of an instance of ReferenceDF holds information about the type of the linked objects and optionally further restrictions, like the class of a config item. This is a bit more restrictive than linking via the link table. The reference entity can't be changed via the dynamic fields.
Lens
The name refers to https://en.wikipedia.org/wiki/Bidirectional_transformation. It allows to read and write a dynamic field of an entity that is available via the Reference DF. Not sure whether that really is bijective. The design explicitly allows for direct manipulation of the internals of another object. So care must be taken when defining a dynamic field of the type Lens. The config of Lens DFs hold dynamic field id of a Reference DF and the dynamic field id of a DF that is supported by the Reference DF.
The text was updated successfully, but these errors were encountered: