Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For PUT/PATCH requests, the body is in param PUTDATA/PATCHDATA #1656

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

reneeb
Copy link
Contributor

@reneeb reneeb commented Mar 10, 2022

If you import the "standard" GenericTicketConnectorREST.yml file and want to update a ticket, one has to use the PATCH HTTP method to send data. The data is in the body, but without this change nothing happens as the HTTP::REST transport class tries to get the query body from the parameter POSTDATA. But that parameter does not exist. Instead the parmeter name depends on the HTTP method used for the request (see https://metacpan.org/dist/CGI/source/lib/CGI.pm#L656). So the HTTP::REST transport class should use those parameter names.

@reneeb reneeb requested a review from bschmalhofer March 10, 2022 14:12
Copy link
Contributor

@bschmalhofer bschmalhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me. Could you create an issues to which this PR can be attached? So that we can properly track the changes.

@svenoe svenoe merged commit fa61f18 into RotherOSS:rel-10_1 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants