Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericInterface: PATCH and PUT requests fail #1657

Closed
reneeb opened this issue Mar 10, 2022 · 3 comments
Closed

GenericInterface: PATCH and PUT requests fail #1657

reneeb opened this issue Mar 10, 2022 · 3 comments
Assignees
@reneeb
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.1.2

Comments

@reneeb
Copy link
Contributor

reneeb commented Mar 10, 2022

The transport class HTTP::REST tries to get the value for the POSTDATA param. But for PATCH and PUT requests that param does not exist. The body is stored in PATCHDATA/PUTDATA.

See PR #1656
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Mar 10, 2022
@bschmalhofer
Copy link
Contributor

This bug seems to have been introduced in rel-10_1. In rel-10_0 the content was read from STDIN which seems to have worked fine for PUT and PATCH too.

@reneeb : please go ahead and merge the PR

svenoe pushed a commit that referenced this issue Mar 10, 2022
@reneeb
Issue #1657: For PUT/PATCH requests, the body is in param PUTDATA/PAT…
fa61f18 
…CHDATA (#1656)
@svenoe svenoe closed this as completed Mar 10, 2022
@bschmalhofer
Copy link
Contributor

bschmalhofer commented Mar 11, 2022 •
edited
Loading

TODO:

  • add tests for PATCH and PUT

@bschmalhofer bschmalhofer reopened this Mar 11, 2022
bschmalhofer added a commit that referenced this issue Mar 11, 2022
@bschmalhofer
Issue #1657: also test PATCH and PUT
c49846e 
in addition to GET and POST
bschmalhofer added a commit that referenced this issue Mar 11, 2022
@bschmalhofer
Merge pull request #1667 from RotherOSS/issue-#1657-test_patch_and_put
2ac0879 
Issue #1657: also test PATCH and PUT
@bschmalhofer
Copy link
Contributor

Tests were added. Closing this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reneeb reneeb

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.1.2
Development

No branches or pull requests
3 participants
@bschmalhofer @reneeb @svenoe