-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/Fix: Ensure members list updates simultaneously when a new member is added #865
base: develop
Are you sure you want to change the base?
Conversation
Hey @smritidoneria |
The useFetchchatdata hook defined the getchannelmember function which fetches the list of channel members and updates the state. the use effect hook in the component calls getChannelMember when the component mounts,ensuring memeberlist is fetched and updated, |
2ef2985
to
8f3bb40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the deployment error
fixed the error @Spiral-Memory . |
Brief Title
This pull request addresses the issue where the members list does not update simultaneously when a new member is added. The solution involves ensuring that the members list is fetched and updated in real-time when the component mounts and when relevant events occur.
Fixes #864
Video/Screenshots
Screen.Recording.2025-01-10.at.7.54.17.PM.mov
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.