Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/Fix: Ensure members list updates simultaneously when a new member is added #865

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

smritidoneria
Copy link
Contributor

Brief Title

This pull request addresses the issue where the members list does not update simultaneously when a new member is added. The solution involves ensuring that the members list is fetched and updated in real-time when the component mounts and when relevant events occur.

Fixes #864

Video/Screenshots

Screen.Recording.2025-01-10.at.7.54.17.PM.mov

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Hey @smritidoneria
Can you pls explain a bit on how you are fixing it ?

@smritidoneria
Copy link
Contributor Author

The useFetchchatdata hook defined the getchannelmember function which fetches the list of channel members and updates the state.

the use effect hook in the component calls getChannelMember when the component mounts,ensuring memeberlist is fetched and updated,

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory Spiral-Memory added testing chore a subtle fix and removed testing labels Jan 27, 2025
@Spiral-Memory
Copy link
Collaborator

image
Hi @smritidoneria
Getting this error on deployment

@Spiral-Memory Spiral-Memory changed the title Fix: Ensure members list updates simultaneously when a new member is added chore/Fix: Ensure members list updates simultaneously when a new member is added Jan 30, 2025
Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the deployment error

@smritidoneria
Copy link
Contributor Author

fixed the error @Spiral-Memory .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a subtle fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Members not updated simultaneously in the sidebar when a new member is added
2 participants