Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[render_client] Re-enable integration tests on Mac #22516

Conversation

nicolecheetham
Copy link
Contributor

@nicolecheetham nicolecheetham commented Jan 23, 2025

Resolves #19305

Various updates have been made to VTK since these test were disabled. Re-enable render_gltf_client integration tests to see if they now work as intended.


This change is Reviewable

@nicolecheetham
Copy link
Contributor Author

@drake-jenkins-bot mac-arm-sequoia-unprovisioned-clang-bazel-experimental-release please

Copy link
Contributor Author

@nicolecheetham nicolecheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sammy-tri for platform review please

Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @nicolecheetham)

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review January 27, 2025 14:26
@jwnimmer-tri jwnimmer-tri added release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html labels Jan 27, 2025
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: both reviews +(status: single reviewer ok).

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee sammy-tri(platform)

@jwnimmer-tri jwnimmer-tri merged commit 362a38d into RobotLocomotion:master Jan 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[render_client] SHA256 mismatch in macOS integration_test
3 participants