Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .deb files to skip per-distro subdirectories in S3 #22471

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+8 −7
Open

Rename .deb files to skip per-distro subdirectories in S3 #22471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e36a766
change platform from per-distro subdirectories to release folder, wit…
tyler-yankee Jan 15, 2025
90188c2
use filename variable (as it is used below)
tyler-yankee Jan 16, 2025
493eecc
improve readability wrt variable naming
tyler-yankee Jan 20, 2025
b92f502
update README to reflect new structure
tyler-yankee Jan 23, 2025
0d46fc3
revert filename change for aptly package database
tyler-yankee Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/release_engineering/dev/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ has `<version>` tags for each supported configuration (e.g. jammy and noble).

1. The `*.deb` files are in AWS
[s3://drake-packages/drake/release](https://s3.console.aws.amazon.com/s3/buckets/drake-packages?region=us-east-1&prefix=drake/release/&showversions=false)
`/<configuration>/drake-dev_<version>-1_amd64.deb` for each supported configuration (e.g. jammy and noble)
`/drake-dev_<version>-1_amd64-<configuration>.deb` for each supported configuration (e.g. jammy and noble)

## Run script for apt

Expand Down
9 changes: 5 additions & 4 deletions tools/release_engineering/dev/push_release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,14 @@ if [[ "${push_apt}" -ne 0 ]]; then
mkdir -p "${platform}"
pushd "${platform}"

filename="drake-dev_${source_version}-1_amd64.deb"
readonly remote_filename="drake-dev_${source_version}-1_amd64-${platform}.deb"
readonly local_filename="drake-dev_${source_version}-1_amd64.deb"

curl --fail --location --remote-name \
"https://drake-packages.csail.mit.edu/drake/release/${platform}/${filename}"
curl --fail --location -o "${local_filename}" \
"https://drake-packages.csail.mit.edu/drake/release/${remote_filename}"

# Add the Debian package to the aptly database.
aptly repo add "drake-${platform}" "${filename}"
aptly repo add "drake-${platform}" "${local_filename}"
aptly snapshot create "drake-${platform}-${source_version}" \
from repo "drake-${platform}"

Expand Down
4 changes: 2 additions & 2 deletions tools/release_engineering/dev/push_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,8 @@ def _push_deb(state: _State):
Downloads .deb artifacts and push them to S3.
"""
for deb in state.find_artifacts(_Manifest.RE_DEB):
dest_name = f'drake-dev_{deb.version}_{deb.arch}.{deb.ext}'
dest_path = f'drake/release/{deb.platform}/{dest_name}'
dest_path_suffix = f'{deb.version}_{deb.arch}-{deb.platform}.{deb.ext}'
dest_path = f'drake/release/drake-dev_{dest_path_suffix}'
state.push_artifact(deb, _AWS_BUCKET, dest_path)


Expand Down