[workspace] Simplify several externals to be platform-agnostic #20606
Conversation
jwnimmer-tri
added
priority: low
status: commits are properly curated
jwnimmer-tri
changed the title
jwnimmer-tri
force-pushed
the
os-portability-4linux
branch
2 times, most recently
from
897d798 to
df6b0ba
Compare
jwnimmer-tri
added
the
status: single reviewer ok
|
@drake-jenkins-bot linux-focal-unprovisioned-gcc-wheel-experimental-release please |
|
+@EricCousineau-TRI for both(?) reviews, please. If you'd like a separate feature reviewer, we could add Rico for that. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r3, 1 of 1 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @jwnimmer-tri)
tools/workspace/mosek/repository.bzl line 33 at r5 (raw file):
mosek_patch_version = 46 os_name = repository_ctx.os.name # 'linux' or 'mac os x'
nit (minor) This file does no mapping,but gurobi mapped from mac os x to darwin.
Is it useful for other if this were consistent?
jwnimmer-tri
force-pushed
the
os-portability-4linux
branch
from
df6b0ba to
c319236
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform), base commit is latest master
tools/workspace/mosek/repository.bzl line 33 at r5 (raw file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
nit (minor) This file does no mapping,but gurobi mapped from
mac os xtodarwin.Is it useful for other if this were consistent?
I went back and forth on different spellings in the various files (both here, and in other related PRs). Your comment was enough to tip this one the other way.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status:
tools/workspace/mosek/repository.bzl line 33 at r5 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
I went back and forth on different spellings in the various files (both here, and in other related PRs). Your comment was enough to tip this one the other way.
Aye, thanks!
We only support exactly one platform, so we can just check for that one directly and drop some vestigial parameterization infrastructure.
jwnimmer-tri
force-pushed
the
os-portability-4linux
branch
from
c319236 to
b1b297b
Compare
Towards #14967. We only want to lock ourselves to specific Ubuntu release numbers in cases where we acutely care. In most cases, we only care about "linux" vs "darwin", not Ubuntu.
This change is