Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified parameters names of RigidBodyLoop and RigidbodyActuator. #2923

Merged
merged 9 commits into from
Jul 26, 2016
Merged

Modified parameters names of RigidBodyLoop and RigidbodyActuator. #2923

merged 9 commits into from
Jul 26, 2016

Conversation

liangfok
Copy link
Contributor

@liangfok liangfok commented Jul 25, 2016 •
edited by david-german-tri
Loading

Resolves #2922.

This change is Reviewable

@liangfok liangfok self-assigned this Jul 25, 2016
@sherm1
Copy link
Member

sherm1 commented Jul 25, 2016

Reviewed 1 of 6 files at r1.
Review status: 1 of 10 files reviewed at latest revision, 1 unresolved discussion.

CHANGELOG.md, line 87 [r1] (raw file):

[#2779]: https://github.com/RobotLocomotion/drake/issues/2779
[#2900]: https://github.com/RobotLocomotion/drake/issues/2900
[#2920]: https://github.com/RobotLocomotion/drake/issues/2920

needs a newline

Comments from Reviewable

@liangfok
Copy link
Contributor Author

Review status: 0 of 10 files reviewed at latest revision, 1 unresolved discussion.

CHANGELOG.md, line 87 [r1] (raw file):

Previously, sherm1 (Michael Sherman) wrote…

needs a newline

Done. Thanks.

Comments from Reviewable

@liangfok liangfok mentioned this pull request Jul 25, 2016
Merged
@liangfok
Copy link
Contributor Author

This PR passed https://drake-jenkins.csail.mit.edu/job/experimental/3062/ and is thus ready for review.

@liangfok
Copy link
Contributor Author

+@amcastro-tri for feature review.

Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@liangfok
Copy link
Contributor Author

+@sherm1 for platform review.

Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@sherm1
Copy link
Member

sherm1 commented Jul 26, 2016

Platform review: :lgtm:

Reviewed 2 of 6 files at r1, 3 of 4 files at r2, 1 of 4 files at r3, 5 of 5 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@liangfok
Copy link
Contributor Author

@sherm1: Thanks! Now waiting on @amcastro-tri for feature review.

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@amcastro-tri
Copy link
Contributor

:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@liangfok liangfok merged commit 5d7b68d into RobotLocomotion:master Jul 26, 2016
@liangfok liangfok deleted the feature/remove_in_parameters_1 branch March 22, 2017 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liangfok liangfok

@sherm1 sherm1

@amcastro-tri amcastro-tri

Labels
priority: high type: cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liangfok @sherm1 @amcastro-tri