Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottle robotlocomotion/director/clang-format@15 #21336

Closed
Tracked by #21335
jwnimmer-tri opened this issue Apr 19, 2024 · 1 comment
Closed
Tracked by #21335

Bottle robotlocomotion/director/clang-format@15 #21336

jwnimmer-tri opened this issue Apr 19, 2024 · 1 comment
Assignees
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: high type: feature request

Comments

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Apr 19, 2024

To support Noble (#21335), we need to bump our clang-format version. (Noble does not have clang-format-12, which is what we currently use.)

I don't think #19295 will be ready in time, so that means we'll need to bottle a new clang-format on macOS so that we have a uniform version on all platforms.

Please create director bottles for clang-format@15 providing clang-format-15.

For reference, here was the brew formula for version 15 when it was the latest:
https://github.com/Homebrew/homebrew-core/blob/04cead37/Formula/clang-format.rb

Or, in the alternative, I wonder if https://formulae.brew.sh/formula/llvm@15 provides a clang-format binary we could use?

@jwnimmer-tri
Copy link
Collaborator Author

Aha, indeed brew llvm@15 gives us /opt/homebrew/opt/llvm@15/bin/clang-format in a jiffy. No need to make a new bottle.

@jwnimmer-tri jwnimmer-tri closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: high type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants